Bug 191892

Summary: [SOUP] Follow-up robustness improvements to the certificate decoder
Product: WebKit Reporter: Claudio Saavedra <csaavedra>
Component: WebKitGTKAssignee: Claudio Saavedra <csaavedra>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, bugs-noreply, cgarcia, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Description Claudio Saavedra 2018-11-21 10:28:47 PST 
[SOUP] Follow-up robustness improvements to the certificate decoder
Comment 1 Claudio Saavedra 2018-11-21 10:31:34 PST 
Created attachment 355427 [details]
Patch
Comment 2 Adrian Perez 2018-11-21 10:39:05 PST 
Comment on attachment 355427 [details]
Patch

Patch LGTM, r+ (informal review, tho :)
Comment 3 Michael Catanzaro 2018-11-21 10:41:54 PST 
Comment on attachment 355427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355427&action=review

Yes and yes, good catches.

> Source/WebCore/ChangeLog:10
> +        is nil, return false from the decoder to notify the failure 

null, what language are you working with here :P
Comment 4 Claudio Saavedra 2018-11-21 10:58:28 PST 
Committed r238426: <https://trac.webkit.org/changeset/238426>