Bug 191892 - [SOUP] Follow-up robustness improvements to the certificate decoder
Summary: [SOUP] Follow-up robustness improvements to the certificate decoder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-21 10:28 PST by Claudio Saavedra
Modified: 2018-11-21 10:58 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.29 KB, patch)
2018-11-21 10:31 PST, Claudio Saavedra 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2018-11-21 10:28:47 PST 
[SOUP] Follow-up robustness improvements to the certificate decoder
Comment 1 Claudio Saavedra 2018-11-21 10:31:34 PST 
Created attachment 355427 [details]
Patch
Comment 2 Adrian Perez 2018-11-21 10:39:05 PST 
Comment on attachment 355427 [details]
Patch

Patch LGTM, r+ (informal review, tho :)
Comment 3 Michael Catanzaro 2018-11-21 10:41:54 PST 
Comment on attachment 355427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355427&action=review

Yes and yes, good catches.

> Source/WebCore/ChangeLog:10
> +        is nil, return false from the decoder to notify the failure 

null, what language are you working with here :P
Comment 4 Claudio Saavedra 2018-11-21 10:58:28 PST 
Committed r238426: <https://trac.webkit.org/changeset/238426>