Bug 191886

Summary: [WebRTC][GStreamer] fast/mediastream/MediaStream-video-element-remove-track.html is failing
Product: WebKit Reporter: Alicia Boya García <aboya>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, dpino, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, pnormand, sergio, tommyw, tsaunier
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210800
Attachments:
Description Flags
Patch
none
Patch calvaris: review+, calvaris: commit-queue-

Description Alicia Boya García 2018-11-21 07:10:10 PST
fast/mediastream/MediaStream-video-element-remove-track.html is failing since r238276-238281

--- /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/layout-test-results/fast/mediastream/MediaStream-video-element-remove-track-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/layout-test-results/fast/mediastream/MediaStream-video-element-remove-track-actual.txt
@@ -39,7 +39,7 @@
 PASS video.videoTracks[0].kind is "main"
 
 **** check no audio track ****
-PASS video.audioTracks.length is 0
+FAIL video.audioTracks.length should be 0. Was 1.
 PASS mediaStream.getAudioTracks().length is 0
 PASS successfullyParsed is true
Comment 1 Philippe Normand 2021-06-17 07:46:40 PDT
Created attachment 431662 [details]
Patch
Comment 2 Philippe Normand 2021-06-17 07:57:04 PDT
Created attachment 431664 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2021-06-17 08:20:30 PDT
Comment on attachment 431664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431664&action=review

> Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:369
> +    auto source = WTFMove(priv->sources[index]);

Please, specify the type here, just in case.
Comment 4 Philippe Normand 2021-06-18 01:03:41 PDT
(In reply to Xabier Rodríguez Calvar from comment #3)
> Comment on attachment 431664 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431664&action=review
> 
> > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:369
> > +    auto source = WTFMove(priv->sources[index]);
> 
> Please, specify the type here, just in case.

In case of?
There is no ambiguity in this case, otherwise the code wouldn't compile. But yeah sure, let's do this just in case :)
Comment 5 Philippe Normand 2021-06-18 01:29:37 PDT
Committed r279033 (238953@main): <https://commits.webkit.org/238953@main>