| Summary: | Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> | ||||||||||||||||||||
| Component: | Layout and Rendering | Assignee: | Javier Fernandez <jfernandez> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, jfernandez, mmaxfield, rego, rniwa, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=170175 | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
Created attachment 355405 [details]
Expected result
Created attachment 355406 [details]
Actual result
Created attachment 355407 [details]
Test case to reproduce the issue
Created attachment 355411 [details]
Patch
Comment on attachment 355411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355411&action=review LGTM, I guess you still need to add the new results for other platforms before landing. > LayoutTests/fast/writing-mode/vertical-align-table-baseline-latin-expected.html:8 > +</style> Nit: I'd add the typical paragraph about when this passes. Comment on attachment 355411 [details] Patch Attachment 355411 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10099721 New failing tests: fast/writing-mode/vertical-align-table-baseline-latin.html Created attachment 355420 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 355411 [details] Patch Attachment 355411 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/10100233 New failing tests: fast/writing-mode/vertical-align-table-baseline.html Created attachment 355423 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 355411 [details] Patch Attachment 355411 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10099992 New failing tests: fast/writing-mode/vertical-align-table-baseline-latin.html Created attachment 355425 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Created attachment 355438 [details]
Patch
Comment on attachment 355438 [details] Patch Clearing flags on attachment: 355438 Committed r238441: <https://trac.webkit.org/changeset/238441> All reviewed patches have been landed. Closing bug. |
Created attachment 355404 [details] Test case to reproduce the issue What steps will reproduce the problem? (1) Load the attached test case (2) (3) What is the expected output? The elements on each column should be aligned using their alphabetic baselines (expected.png) What do you see instead? The items are not aligned at all; the table may be using hanging baseline, but not sure (result.png)