Bug 191873

Summary: [LFC][IFC] Take nonBreakableStart/End into use.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+

zalan
Reported 2018-11-20 20:30:51 PST
to offset the final inline runs.
Attachments
Patch (25.40 KB, patch)
2018-11-20 21:50 PST, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-11-20 21:50:28 PST
Created attachment 355383 [details] Patch
Antti Koivisto
Comment 2 2018-11-21 06:52:05 PST
Comment on attachment 355383 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355383&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:148 > unsigned uncommittedLength = 0; > InlineItem* firstUncommittedInlineItem = nullptr; > + InlineItem* lastUncommittedInlineItem = nullptr; Maybe these could alternatively be something like struct Uncommitted { unsigned length { 0 }; InlineItem& firstInlineItem; InlineItem& lastInlineItem; }; std::optional<Uncommitted> uncommitted; since these are always used together?
zalan
Comment 3 2018-11-21 07:41:52 PST
Committed r238415: <https://trac.webkit.org/changeset/238415>
Radar WebKit Bug Importer
Comment 4 2018-11-21 07:42:29 PST
<rdar://problem/46201523>
Note You need to log in before you can comment on or make changes to this bug.