Bug 191869

Summary:

Merging an IC variant may lead to the IC status containing overlapping structure sets

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, fpizlo, ggaren, gskachkov, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	mark.lam: review+
patch for landing	none

Description Saam Barati 2018-11-20 15:58:57 PST

We should check once we merge a variant that we haven't created a situation where more than two or more variants contain overlapping structure sets.

Comment 1 Saam Barati 2018-11-20 15:59:32 PST

<rdar://problem/45403453>

Comment 2 Saam Barati 2018-11-20 16:16:47 PST

Created attachment 355369 [details]
patch

Comment 3 Mark Lam 2018-11-20 16:57:22 PST

Comment on attachment 355369 [details]
patch

r=me

Comment 4 Saam Barati 2018-11-20 20:36:45 PST

Created attachment 355379 [details]
patch for landing

Comment 5 WebKit Commit Bot 2018-11-20 21:15:38 PST

Comment on attachment 355379 [details]
patch for landing

Clearing flags on attachment: 355379

Committed r238411: <https://trac.webkit.org/changeset/238411>

Comment 6 WebKit Commit Bot 2018-11-20 21:15:40 PST

All reviewed patches have been landed.  Closing bug.