Bug 191866

Summary: Better parsing of comments in generate-message*.py
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, lforschler, ossy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Rollin
Reported 2018-11-20 13:02:48 PST
The script parsing the *.messages.in files would treat a line starting with '#' as a comment, but not a line starting with '<whitespace>#'. This means that jamming a '#' right in front of the first character of a message definition (as opposed to the beginning of a line) will have no effect and the line will get treated just the same as a non-commented line. Fix this by trimming all white space from the beginning and ending of the line before processing it.
Attachments
Patch (4.26 KB, patch)
2018-11-20 13:06 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Patch (3.30 KB, patch)
2018-11-27 12:59 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-20 13:03:30 PST
<rdar://problem/46189563>
Keith Rollin
Comment 2 2018-11-20 13:06:23 PST
Created attachment 355358 [details] Patch
Chris Dumez
Comment 3 2018-11-27 12:51:26 PST
Comment on attachment 355358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355358&action=review r=me > Source/WebKit/Scripts/Makefile:8 > + grep FakeLoadURL webkit/*-expected.* && "### Test failure: found commented-out functions in output" || true I do not think we need this check here. Since you added comments to test-messages.in and webkit/MessageReceiver-expected.cpp did not change, it is validation enough.
Keith Rollin
Comment 4 2018-11-27 12:59:04 PST
Created attachment 355766 [details] Patch
WebKit Commit Bot
Comment 5 2018-11-27 14:13:02 PST
Comment on attachment 355766 [details] Patch Clearing flags on attachment: 355766 Committed r238577: <https://trac.webkit.org/changeset/238577>
WebKit Commit Bot
Comment 6 2018-11-27 14:13:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.