Bug 191856

Summary: Remove invalid assertion in VMTraps::SignalSender's SignalAction.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
ysuzuki: review+
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Description Mark Lam 2018-11-20 00:46:48 PST
<rdar://problem/46089992>
Comment 1 Mark Lam 2018-11-20 01:14:22 PST
Created attachment 355323 [details]
proposed patch.

Let's try this on the EWS.
Comment 2 EWS Watchlist 2018-11-20 03:32:56 PST
Comment on attachment 355323 [details]
proposed patch.

Attachment 355323 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10086372

New failing tests:
media/no-fullscreen-when-hidden.html
Comment 3 EWS Watchlist 2018-11-20 03:32:57 PST
Created attachment 355332 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 4 Mark Lam 2018-11-20 08:05:32 PST
(In reply to Build Bot from comment #3)
> Created attachment 355332 [details]
> Archive of layout-test-results from ews125 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

I'm quite sure that the watchdog cannot affect this test.
Comment 5 Yusuke Suzuki 2018-11-21 00:22:43 PST
Comment on attachment 355323 [details]
proposed patch.

r=me
Comment 6 Mark Lam 2018-11-21 09:38:32 PST
Thanks for the review.  Landed in r238421: <http://trac.webkit.org/r238421>.