Summary: | Remove @no-unify of InjectedBundleRangeHandle.cpp and InjectedBundleNodeHandle.cpp | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||
Component: | WebKit2 | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||
Status: | REOPENED --- | ||||||||||
Severity: | Normal | CC: | aakash_jain, commit-queue, ews-watchlist, keith_miller, mark.lam, mcatanzaro, ryanhaddad, thorton, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=189467 https://bugs.webkit.org/show_bug.cgi?id=189400 |
||||||||||
Bug Depends on: | 191909, 191995 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Fujii Hironori
2018-11-19 23:35:08 PST
Created attachment 355316 [details]
Patch
Comment on attachment 355316 [details] Patch Attachment 355316 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10085543 New failing tests: media/no-fullscreen-when-hidden.html Created attachment 355327 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Nice Comment on attachment 355316 [details] Patch Clearing flags on attachment: 355316 Committed r238432: <https://trac.webkit.org/changeset/238432> All reviewed patches have been landed. Closing bug. r238432 was rolled out in r238446: <http://trac.webkit.org/r238446>. I'm not sure we actually need to land this patch (since it doesn't add much value). We rolled it out because it introduced a build breakage in internal Mac builds. (In reply to Mark Lam from comment #9) > I'm not sure we actually need to land this patch (since it doesn't add much > value). We rolled it out because it introduced a build breakage in internal > Mac builds. Thanks Mark, I was about to roll this out. Can you post a build log? Maybe we need an EWS for the internal builds; otherwise it's not really possible to avoid breaking it. Especially with unified builds. If you have different unified source bundles in the internal build, all bets are off.... (In reply to Michael Catanzaro from comment #12) > Maybe we need an EWS for the internal builds; otherwise it's not really > possible to avoid breaking it. Especially with unified builds. If you have > different unified source bundles in the internal build, all bets are off.... That's a bit tricky to do safely. Anyway, in this particular case it looks like the usual problem of "someone's got a 'using namespace WebCore' nearby the changed file". Could be WKBundlePageOverlay Created attachment 355829 [details] Patch for landing Bug 191995 has addressed. Can I try again? (In reply to Fujii Hironori from comment #15) > Created attachment 355829 [details] > Patch for landing > > Bug 191995 has addressed. Can I try again? I don’t see why not! (Though I will note that morning PST would probably be a better bet if you want someone on #webkit to check on the internal builds). Hmm, it doesn't sound good to me (I'll be sleeping in the time). I'd like to ask Apple folks to land my patch in morning. Landing it now. Comment on attachment 355829 [details] Patch for landing Clearing flags on attachment: 355829 Committed r238620: <https://trac.webkit.org/changeset/238620> All reviewed patches have been landed. Closing bug. Reverted r238620 for reason: Broke internal builds again. Committed r238625: <https://trac.webkit.org/changeset/238625> Sorry for the churn here. Someone will work with you in the next few days to get this sorted out. |