Bug 191851

Summary:

Document::focusNavigationStartingNode doesn't take shadow tree into account

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

UI Events

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

cfleizach, jcraig, koivisto, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=191694

Bug Depends on:

Bug Blocks:

148695

Attachments:

Description	Flags
A patch to add a test case	none

Description Ryosuke Niwa 2018-11-19 22:16:41 PST

Document::focusNavigationStartingNode needs to take shadow tree and slotted content into account.

This is a bit tricky because this code needs to traverse the composed tree forward & backward.

Comment 1 Ryosuke Niwa 2018-11-19 22:18:10 PST

Antti, what do you think about adding the support for traversing backwards to ElementAndTextDescendantIterator and ComposedTreeIterator?

Comment 2 Radar WebKit Bug Importer 2018-11-19 22:18:41 PST

<rdar://problem/46178587>

Comment 3 Ryosuke Niwa 2018-11-19 22:21:42 PST

Created attachment 355311 [details]
A patch to add a test case

Comment 4 Antti Koivisto 2018-11-20 06:13:42 PST

(In reply to Ryosuke Niwa from comment #1)
> Antti, what do you think about adding the support for traversing backwards
> to ElementAndTextDescendantIterator and ComposedTreeIterator?

Good idea!