| Summary: | [GTK][WPE] Solve some issues in the enumerateDevices code | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alejandro G. Castro <alex> | ||||||
| Component: | WebRTC | Assignee: | Alejandro G. Castro <alex> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | berto, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alejandro G. Castro
2018-11-19 03:39:33 PST
Created attachment 355263 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 355263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355263&action=review > Source/WebKit/UIProcess/API/gtk/WebKitWebsiteData.h:52 > - * Since: 2.16 > + * Since: 2.24 This was correct. You need to add the since tag after the new item added to the enum. > Source/WebKit/UIProcess/API/wpe/WebKitWebsiteData.h:52 > - * Since: 2.16 > + * Since: 2.24 Ditto. Created attachment 355266 [details]
Patch for landing
Comment on attachment 355266 [details] Patch for landing Clearing flags on attachment: 355266 Committed r238372: <https://trac.webkit.org/changeset/238372> All reviewed patches have been landed. Closing bug. |