Bug 191832

Summary: [GTK][WPE] Solve some issues in the enumerateDevices code
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebRTCAssignee: Alejandro G. Castro <alex>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Alejandro G. Castro
Reported 2018-11-19 03:39:33 PST
Address the issues pointed out here: https://bugs.webkit.org/show_bug.cgi?id=185761#c69
Attachments
Patch (12.31 KB, patch)
2018-11-19 03:47 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.92 KB, patch)
2018-11-19 04:38 PST, Alejandro G. Castro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2018-11-19 03:47:30 PST
Created attachment 355263 [details] Patch
EWS Watchlist
Comment 2 2018-11-19 03:49:11 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2018-11-19 04:13:50 PST
Comment on attachment 355263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355263&action=review > Source/WebKit/UIProcess/API/gtk/WebKitWebsiteData.h:52 > - * Since: 2.16 > + * Since: 2.24 This was correct. You need to add the since tag after the new item added to the enum. > Source/WebKit/UIProcess/API/wpe/WebKitWebsiteData.h:52 > - * Since: 2.16 > + * Since: 2.24 Ditto.
Alejandro G. Castro
Comment 4 2018-11-19 04:38:09 PST
Created attachment 355266 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-11-19 05:16:22 PST
Comment on attachment 355266 [details] Patch for landing Clearing flags on attachment: 355266 Committed r238372: <https://trac.webkit.org/changeset/238372>
WebKit Commit Bot
Comment 6 2018-11-19 05:16:24 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-19 05:17:26 PST
<rdar://problem/46167455>
Note You need to log in before you can comment on or make changes to this bug.