Bug 191831

Summary: [CMake] Remove ENABLE_ACCESSIBILITY CMake variable
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: CMakeAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, mcatanzaro, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=199625
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2018-11-19 02:03:17 PST
[CMake] Remove ENABLE_ACCESSIBILITY CMake variable It is confusing with HAVE_ACCESSIBILITY macro. It is used only in WebKitTestRunner. https://github.com/WebKit/webkit/blob/dea6e0141a5df7b678221d4a474b5846176a913d/Tools/WebKitTestRunner/CMakeLists.txt#L76 All CMake ports except AppleWin set ENABLE_ACCESSIBILITY=1. Only AppleWin port set ENABLE_ACCESSIBILITY=0, but it doesn't build WebKitTestRunner. If AppleWin port will use WebKitTestRunner in the future, it will set ENABLE_ACCESSIBILITY=1 because AppleWin port also defines HAVE_ACCESSIBILITY=1. [webkit-dev] Remove HAVE_ACCESSIBILITY https://lists.webkit.org/pipermail/webkit-dev/2018-November/030251.html
Attachments
Patch (7.26 KB, patch)
2018-11-25 20:11 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-11-25 20:11:43 PST
Created attachment 355615 [details] Patch
Fujii Hironori
Comment 2 2018-11-26 17:55:52 PST
Comment on attachment 355615 [details] Patch Clearing flags on attachment: 355615 Committed r238539: <https://trac.webkit.org/changeset/238539>
Fujii Hironori
Comment 3 2018-11-26 17:55:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.