Bug 191810

Summary: Clarify RenderLayerCompositor::hasAnyAdditionalCompositedLayers() and related code.
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zalan: review+

Simon Fraser (smfr)
Reported 2018-11-17 14:03:12 PST
Clarify RenderLayerCompositor::hasAnyAdditionalCompositedLayers() and related code.
Attachments
Patch (8.47 KB, patch)
2018-11-17 14:03 PST, Simon Fraser (smfr) 		zalan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-11-17 14:03:40 PST
Created attachment 355202 [details] Patch
alan
Comment 2 2018-11-17 14:08:08 PST
Comment on attachment 355202 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355202&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:1257 > + if (&layer != m_renderView.layer()) { > + ASSERT(m_contentLayersCount > 0); > + --m_contentLayersCount; > + } Don't we prefer the early return style? if (&layer == m_renderView.layer()) return;
Radar WebKit Bug Importer
Comment 4 2018-11-17 16:53:33 PST
<rdar://problem/46152495>
Note You need to log in before you can comment on or make changes to this bug.