Bug 191808

Summary:

Rename RenderLayerCompositor::inCompositingMode() to usesCompositing()

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zalan: review+

Description Simon Fraser (smfr) 2018-11-17 11:07:13 PST

Rename RenderLayerCompositor::inCompositingMode() to usesCompositing()

Comment 1 Simon Fraser (smfr) 2018-11-17 11:07:56 PST

Created attachment 355196 [details]
Patch

Comment 2 zalan 2018-11-17 11:44:42 PST

Comment on attachment 355196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355196&action=review

> Source/WebCore/page/FrameView.cpp:2412
>          clearBackingStores();

I'd go even one step further and move clearBackingStore() into a lambda since no one else calls into it (it's public on FrameView!) and then you could even drop some lines from clearBackingStores (assert and the renderView() check)

Comment 3 Simon Fraser (smfr) 2018-11-17 16:52:09 PST

https://trac.webkit.org/changeset/238352/webkit

Comment 4 Radar WebKit Bug Importer 2018-11-17 16:53:25 PST

<rdar://problem/46152492>