Bug 191769

Summary:

webkitpy: Retry app installation on watchOS simulators

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, glenn, lforschler

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Jonathan Bedard

Reported 2018-11-16 13:56:19 PST

It takes a few seconds for apps to be installable on freshly booted watchOS simulators.

Attachments
Patch (1.73 KB, patch) 2018-11-16 14:00 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (2.04 KB, patch) 2018-11-16 14:18 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (2.11 KB, patch) 2018-11-16 14:41 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (2.10 KB, patch) 2018-11-16 15:22 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (1.14 KB, patch) 2018-11-26 11:09 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2018-11-16 14:00:01 PST

Created attachment 355115 [details] Patch

Aakash Jain

Comment 2 2018-11-16 14:04:20 PST

Comment on attachment 355115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355115&action=review r=me after the changes. > Tools/Scripts/webkitpy/xcode/simulated_device.py:548 > + for i in xrange(3): Please move 3 to a variable. e.g.: NUM_RETRIES_FOR_WATCH_INSTALL > Tools/Scripts/webkitpy/xcode/simulated_device.py:552 > + if exit_code != 204: what does 204 indicate? maybe worth adding a comment. > Tools/Scripts/webkitpy/xcode/simulated_device.py:553 > + break why break instead of return?

Jonathan Bedard

Comment 3 2018-11-16 14:18:52 PST

Created attachment 355120 [details] Patch

Radar WebKit Bug Importer

Comment 4 2018-11-16 14:28:53 PST

<rdar://problem/46139850>

Aakash Jain

Comment 5 2018-11-16 14:32:25 PST

Comment on attachment 355120 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355120&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:553 > + # Return code indicates that the devices is booting and a retry may be successful. This is confusing. Which return code indicates device is booting? If 204 indicates booting, then it might be simpler/more-readable to check for 204. something like: elif exit_code == 204: # Return code 204 indicates that the devices is booting. Retry after 5s. time.sleep(5) else: return False return False

Jonathan Bedard

Comment 6 2018-11-16 14:41:44 PST

Created attachment 355128 [details] Patch

Jonathan Bedard

Comment 7 2018-11-16 15:22:34 PST

Created attachment 355139 [details] Patch

WebKit Commit Bot

Comment 8 2018-11-16 16:02:23 PST

Comment on attachment 355139 [details] Patch Clearing flags on attachment: 355139 Committed r238319: <https://trac.webkit.org/changeset/238319>

WebKit Commit Bot

Comment 9 2018-11-16 16:02:24 PST

All reviewed patches have been landed. Closing bug.