Bug 191744

Summary: [GTK][WPE] Add "WebKitDeviceInfoPermissionRequest.h" into webkit2.h
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 191585    
Attachments:
Description Flags
Patch
none
Patch for landing none

Thibault Saunier
Reported 2018-11-16 05:11:05 PST
[GTK] Add "WebKitDeviceInfoPermissionRequest.h" into webkit2.h
Attachments
Patch (1.27 KB, patch)
2018-11-16 05:11 PST, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.83 KB, patch)
2018-11-16 05:35 PST, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-11-16 05:11:31 PST
Created attachment 355045 [details] Patch
EWS Watchlist
Comment 2 2018-11-16 05:14:12 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2018-11-16 05:18:41 PST
Comment on attachment 355045 [details] Patch Thanks. Note that it's missing in the WPE header too. Feel free to either make this bug [GTK][WPE] and add it there too or use a different bug if you want.
Thibault Saunier
Comment 4 2018-11-16 05:35:33 PST
Created attachment 355050 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-11-16 06:02:48 PST
Comment on attachment 355050 [details] Patch for landing Clearing flags on attachment: 355050 Committed r238277: <https://trac.webkit.org/changeset/238277>
WebKit Commit Bot
Comment 6 2018-11-16 06:02:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-16 06:04:13 PST
<rdar://problem/46125461>
Michael Catanzaro
Comment 8 2018-11-16 15:52:24 PST
Committed r238318: <https://trac.webkit.org/changeset/238318>
Note You need to log in before you can comment on or make changes to this bug.