Bug 191744 - [GTK][WPE] Add "WebKitDeviceInfoPermissionRequest.h" into webkit2.h
Summary: [GTK][WPE] Add "WebKitDeviceInfoPermissionRequest.h" into webkit2.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on:
Blocks: 191585
  Show dependency tree / graph
 
Reported: 2018-11-16 05:11 PST by Thibault Saunier
Modified: 2018-11-16 15:52 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.27 KB, patch)
2018-11-16 05:11 PST, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch for landing (1.83 KB, patch)
2018-11-16 05:35 PST, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-11-16 05:11:05 PST 
[GTK] Add "WebKitDeviceInfoPermissionRequest.h" into webkit2.h
Comment 1 Thibault Saunier 2018-11-16 05:11:31 PST 
Created attachment 355045 [details]
Patch
Comment 2 EWS Watchlist 2018-11-16 05:14:12 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2018-11-16 05:18:41 PST 
Comment on attachment 355045 [details]
Patch

Thanks. Note that it's missing in the WPE header too. Feel free to either make this bug [GTK][WPE]  and add it there too or use a different bug if you want.
Comment 4 Thibault Saunier 2018-11-16 05:35:33 PST 
Created attachment 355050 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-11-16 06:02:48 PST 
Comment on attachment 355050 [details]
Patch for landing

Clearing flags on attachment: 355050

Committed r238277: <https://trac.webkit.org/changeset/238277>
Comment 6 WebKit Commit Bot 2018-11-16 06:02:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-16 06:04:13 PST 
<rdar://problem/46125461>
Comment 8 Michael Catanzaro 2018-11-16 15:52:24 PST 
Committed r238318: <https://trac.webkit.org/changeset/238318>