Bug 191699

Summary: [GStreamer][WebRTC] Add API to enable/disable device mocks
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Thibault Saunier
Reported 2018-11-15 11:47:31 PST
[GStreamer][WebRTC] Add API to enable/disable device mocks
Attachments
Patch (11.92 KB, patch)
2018-11-15 11:48 PST, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch (12.87 KB, patch)
2018-11-15 12:48 PST, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.01 KB, patch)
2018-11-16 05:31 PST, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-11-15 11:48:35 PST
Created attachment 354965 [details] Patch
Thibault Saunier
Comment 2 2018-11-15 12:48:21 PST
Created attachment 354973 [details] Patch
Xabier Rodríguez Calvar
Comment 3 2018-11-15 23:41:36 PST
Comment on attachment 354973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354973&action=review > Source/WebCore/ChangeLog:15 > + stream is similare to what Apple port does. similar > Source/WebKit/ChangeLog:15 > + stream is similare to what Apple port does. similar > Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:-163 > - if (newSink == m_sink.get()) { > - GST_INFO_OBJECT(m_pipeline.get(), "Setting queue as leaky upstream" > - " so that the player can set the sink to PAUSED without " > - " setting the whole capturer to PAUSED"); > - g_object_set(queue, "leaky", 2 /* upstream */, nullptr); > - } If you remove this piece of code, you also want to remove one of the spaces, either below os above to avoid having a double empty line.
Thibault Saunier
Comment 4 2018-11-16 05:31:23 PST
Created attachment 355049 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-11-16 06:09:49 PST
Comment on attachment 355049 [details] Patch for landing Clearing flags on attachment: 355049 Committed r238278: <https://trac.webkit.org/changeset/238278>
WebKit Commit Bot
Comment 6 2018-11-16 06:09:51 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-11-16 06:12:09 PST
<rdar://problem/46125549>
Note You need to log in before you can comment on or make changes to this bug.