Bug 191670

Summary: Move scripts for Derived and Unified Sources to external files
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, keith_miller, lforschler, mark.lam, mitz, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Rebase and try again none

Keith Rollin
Reported 2018-11-14 17:29:21 PST
Move the scripts in the Generate Derived Sources and Generate Unified Sources Run Script phases from the Xcode projects to external shell script files. Then invoke those scripts from the Run Script phases. This refactoring is being performed to support later work that will invoke these scripts in other contexts. The scripts were maintained as-is when making the move. I did a little reformatting and added 'set -e' to the top of each file, but that's it.
Attachments
Patch (25.83 KB, patch)
2018-11-14 17:33 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Rebase and try again (21.92 KB, patch)
2018-11-14 17:39 PST, Keith Rollin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-14 17:30:07 PST
<rdar://problem/46082278>
Keith Rollin
Comment 2 2018-11-14 17:33:19 PST
Created attachment 354877 [details] Patch
Keith Rollin
Comment 3 2018-11-14 17:39:25 PST
Created attachment 354878 [details] Rebase and try again
Keith Miller
Comment 4 2018-11-14 19:22:29 PST
Comment on attachment 354878 [details] Rebase and try again r=me.
WebKit Commit Bot
Comment 5 2018-11-14 22:01:22 PST
Comment on attachment 354878 [details] Rebase and try again Clearing flags on attachment: 354878 Committed r238219: <https://trac.webkit.org/changeset/238219>
WebKit Commit Bot
Comment 6 2018-11-14 22:01:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.