Bug 191655

Summary:

Have prefers-color-scheme: light always match on macOS versions before Mojave

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

CSS

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, ews-watchlist, megan_gardner, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Patch	none

Description Timothy Hatcher 2018-11-14 14:05:38 PST

Currently @media (prefers-color-scheme: light) is invalid on macOS before Mojave, but those systems only had light mode and we should match in that case. I'm not sure how common this case might be going forward, given that all other browsers don't support prefers-color-scheme yet.

Comment 1 Radar WebKit Bug Importer 2018-11-14 14:06:02 PST

<rdar://problem/46074680>

Comment 2 Simon Fraser (smfr) 2018-11-14 14:06:44 PST

Seems worth doing.

Comment 3 Timothy Hatcher 2019-01-11 17:31:04 PST Comment hidden (obsolete)

Created attachment 358967 [details]
Patch

Comment 4 Megan Gardner 2019-01-11 17:40:18 PST

Comment on attachment 358967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358967&action=review

> Source/WebCore/page/Page.cpp:2679
>  }

Does 'value' not need to be marked as UNUSED?

> Source/WebCore/page/Page.cpp:2704
> +#endif

Does 'valueOverride' not need to be marked as UNUSED?

Comment 5 Timothy Hatcher 2019-01-11 21:33:20 PST Comment hidden (obsolete)

Created attachment 358982 [details]
Patch

Comment 6 Timothy Hatcher 2019-01-12 10:06:30 PST Comment hidden (obsolete)

Created attachment 358992 [details]
Patch

Comment 7 Timothy Hatcher 2019-01-12 10:29:11 PST Comment hidden (obsolete)

Created attachment 358993 [details]
Patch

Comment 8 EWS Watchlist 2019-01-12 17:11:37 PST Comment hidden (obsolete)

Comment on attachment 358993 [details]
Patch

Attachment 358993 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10728673

New failing tests:
css-dark-mode/older-systems/supported-color-schemes-css.html
css-dark-mode/older-systems/supported-color-schemes.html

Comment 9 EWS Watchlist 2019-01-12 17:11:39 PST Comment hidden (obsolete)

Created attachment 358997 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

Comment 10 Timothy Hatcher 2019-01-12 18:18:03 PST

Created attachment 358998 [details]
Patch

Comment 11 WebKit Commit Bot 2019-01-12 21:54:13 PST

Comment on attachment 358998 [details]
Patch

Clearing flags on attachment: 358998

Committed r239904: <https://trac.webkit.org/changeset/239904>

Comment 12 WebKit Commit Bot 2019-01-12 21:54:14 PST

All reviewed patches have been landed.  Closing bug.