Bug 191655

Summary:

Have prefers-color-scheme: light always match on macOS versions before Mojave

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

CSS

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, ews-watchlist, megan_gardner, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-highsierra-wk2	none
Patch	none

Timothy Hatcher

Reported 2018-11-14 14:05:38 PST

Currently @media (prefers-color-scheme: light) is invalid on macOS before Mojave, but those systems only had light mode and we should match in that case. I'm not sure how common this case might be going forward, given that all other browsers don't support prefers-color-scheme yet.

Attachments
Patch (42.26 KB, patch) 2019-01-11 17:31 PST, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (42.32 KB, patch) 2019-01-11 21:33 PST, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (46.27 KB, patch) 2019-01-12 10:06 PST, Timothy Hatcher	no flags	Details Formatted Diff Diff
Patch (42.94 KB, patch) 2019-01-12 10:29 PST, Timothy Hatcher	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.61 MB, application/zip) 2019-01-12 17:11 PST, EWS Watchlist	no flags	Details
Patch (42.94 KB, patch) 2019-01-12 18:18 PST, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-11-14 14:06:02 PST

<rdar://problem/46074680>

Simon Fraser (smfr)

Comment 2 2018-11-14 14:06:44 PST

Seems worth doing.

Timothy Hatcher

Comment 3 2019-01-11 17:31:04 PST Comment hidden (obsolete)

Created attachment 358967 [details] Patch

Megan Gardner

Comment 4 2019-01-11 17:40:18 PST

Comment on attachment 358967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358967&action=review > Source/WebCore/page/Page.cpp:2679 > } Does 'value' not need to be marked as UNUSED? > Source/WebCore/page/Page.cpp:2704 > +#endif Does 'valueOverride' not need to be marked as UNUSED?

Timothy Hatcher

Comment 5 2019-01-11 21:33:20 PST Comment hidden (obsolete)

Created attachment 358982 [details] Patch

Timothy Hatcher

Comment 6 2019-01-12 10:06:30 PST Comment hidden (obsolete)

Created attachment 358992 [details] Patch

Timothy Hatcher

Comment 7 2019-01-12 10:29:11 PST Comment hidden (obsolete)

Created attachment 358993 [details] Patch

EWS Watchlist

Comment 8 2019-01-12 17:11:37 PST Comment hidden (obsolete)

Comment on attachment 358993 [details] Patch Attachment 358993 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10728673 New failing tests: css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html

EWS Watchlist

Comment 9 2019-01-12 17:11:39 PST Comment hidden (obsolete)

Created attachment 358997 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Timothy Hatcher

Comment 10 2019-01-12 18:18:03 PST

Created attachment 358998 [details] Patch

WebKit Commit Bot

Comment 11 2019-01-12 21:54:13 PST

Comment on attachment 358998 [details] Patch Clearing flags on attachment: 358998 Committed r239904: <https://trac.webkit.org/changeset/239904>

WebKit Commit Bot

Comment 12 2019-01-12 21:54:14 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.