Bug 191624

Summary: WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, rniwa, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 191572    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2018-11-13 21:34:32 PST
TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool API test is failing with process prewarming is enabled:
    TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:473
        Expected equality of these values:
          "PersistentCookieName=CookieValue; SessionCookieName=CookieValue"
          message.UTF8String
            Which is: "PersistentCookieName=CookieValue"
Comment 1 Chris Dumez 2018-11-13 21:58:34 PST
Created attachment 354770 [details]
Patch
Comment 2 Alex Christensen 2018-11-14 06:07:28 PST
Comment on attachment 354770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354770&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:482
> +enum ShouldEnableProcessPrewarming { No, Yes };

enum class
Comment 3 Chris Dumez 2018-11-14 07:04:58 PST
(In reply to Alex Christensen from comment #2)
> Comment on attachment 354770 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354770&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:482
> > +enum ShouldEnableProcessPrewarming { No, Yes };
> 
> enum class

Oh, duh...
Comment 4 Chris Dumez 2018-11-14 07:32:32 PST
Created attachment 354809 [details]
Patch
Comment 5 WebKit Commit Bot 2018-11-14 07:50:13 PST
Comment on attachment 354809 [details]
Patch

Clearing flags on attachment: 354809

Committed r238174: <https://trac.webkit.org/changeset/238174>
Comment 6 WebKit Commit Bot 2018-11-14 07:50:15 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-14 07:51:44 PST
<rdar://problem/46062884>