Bug 191623

Summary:

[LFC][IFC] Construct dedicated runs when the inline element requires it (part 2)

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description zalan 2018-11-13 21:29:34 PST

expanding original breaking behavior with separate left/right

Comment 1 zalan 2018-11-13 21:48:38 PST

Created attachment 354769 [details]
Patch

Comment 2 Antti Koivisto 2018-11-14 06:44:46 PST

Comment on attachment 354769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354769&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:420
> +    std::function<void(const Box&)> collectInlineContentForSubtree = [&](const Box& root) {

We usually use WTF::Function in WebKit. Also invoking these has a cost since it involves a virtual function. It might be better to factor into a regular function when this becomes necessary.

Comment 3 zalan 2018-11-14 07:31:25 PST

Committed r238173: <https://trac.webkit.org/changeset/238173>

Comment 4 Radar WebKit Bug Importer 2018-11-14 07:33:32 PST

<rdar://problem/46062578>