Bug 191620

Summary: [curl] Unify CookieJarCurlDatabase and the abstract class CookieJarCurl
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: PlatformAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, commit-queue, don.olmstead, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2018-11-13 19:19:46 PST
[curl] Unify CookieJarCurlDatabase and the abstract class CookieJarCurl Based on the Basuke's comment. (In reply to Basuke Suzuki from bug #191582 comment #3) > > I'm honestly wondering why there's a CookieJarCurl at all. There's no cpp > > file and I just see an implementation in CookieJarCurlDatabase. Maybe this > > should just be collapsed? > > This must be the left over of cookie backend abstraction. It had been a file > based storage and when the introduction of sqlite based backend, the > clients, such as NetworkStorageSession, just used interface to communicate > with backend. > > I agree with removing this abstraction because we already took out the file > based backend.
Attachments
Patch (25.49 KB, patch)
2018-11-13 19:26 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-11-13 19:26:01 PST
Created attachment 354754 [details] Patch
Don Olmstead
Comment 2 2018-11-13 21:01:56 PST
LGTM
WebKit Commit Bot
Comment 3 2018-11-14 08:14:25 PST
Comment on attachment 354754 [details] Patch Clearing flags on attachment: 354754 Committed r238176: <https://trac.webkit.org/changeset/238176>
WebKit Commit Bot
Comment 4 2018-11-14 08:14:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-11-14 08:15:27 PST
<rdar://problem/46063373>
Note You need to log in before you can comment on or make changes to this bug.