Bug 191614

Summary: [SOUP] Make Accept-Languages header look more like other browsers
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, commit-queue, ews-watchlist, gustavo, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch none

Michael Catanzaro
Reported 2018-11-13 17:32:42 PST
Remove extra spaces from Accept-Languages header Firefox header: Accept-Language: en-US,en;q=0.7,es-ES;q=0.3 Chrome header: Accept-Language: en-US,en;q=0.9,es;q=0.8 Epiphany before: Accept-Language: en-us, en;q=0.90, es-es;q=0.80, es;q=0.70 Epiphany after: Accept-Language: en-us,en;q=0.90,es-es;q=0.80,es;q=0.70 (Probably should stop lowercasing it too, but that's Epiphany, not WebKit, doing that.)
Attachments
Patch (1.90 KB, patch)
2018-11-13 17:42 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2018-11-13 18:26 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2018-11-13 17:42:59 PST
Created attachment 354738 [details] Patch
Michael Catanzaro
Comment 2 2018-11-13 17:54:06 PST
(In reply to Michael Catanzaro from comment #0) > (Probably should stop lowercasing it too, but that's Epiphany, not WebKit, > doing that.) Actually we have redundant code in both Epiphany and WebKit to do this. I'm not sure why. Clearly other browsers do not downcase the languages.
Michael Catanzaro
Comment 3 2018-11-13 18:26:06 PST
Created attachment 354748 [details] Patch
EWS Watchlist
Comment 4 2018-11-13 18:29:50 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 5 2018-11-15 11:44:06 PST
Comment on attachment 354748 [details] Patch Clearing flags on attachment: 354748 Committed r238236: <https://trac.webkit.org/changeset/238236>
WebKit Commit Bot
Comment 6 2018-11-15 11:44:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.