Bug 191605

Summary: [Cocoa] [WebKit2] Hook up some more editing actions (-pasteAndMatchStyle:, -makeTextWritingDirectionNatural:)
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, dino, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix non-internal iOS build
dino: review+
Patch for landing none

Wenson Hsieh
Reported 2018-11-13 15:26:21 PST
<rdar://problem/45813991>
Attachments
Patch (13.38 KB, patch)
2018-11-13 16:48 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Fix non-internal iOS build (13.87 KB, patch)
2018-11-14 07:31 PST, Wenson Hsieh 		dino: review+
DetailsFormatted DiffDiff
Patch for landing (13.97 KB, patch)
2018-11-14 10:21 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-11-13 16:48:18 PST
Created attachment 354730 [details] Patch
Wenson Hsieh
Comment 2 2018-11-14 07:31:50 PST
Created attachment 354808 [details] Fix non-internal iOS build
Wenson Hsieh
Comment 3 2018-11-14 10:14:40 PST
Comment on attachment 354808 [details] Fix non-internal iOS build View in context: https://bugs.webkit.org/attachment.cgi?id=354808&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:250 > + auto destination = webViewForEditActionTesting(@"<div><br></div>"); Hm...I just realized, I might have to tweak this test a bit to work around <https://webkit.org/b/190401>. I'm going to move this line: `auto destination = webViewForEditActionTesting(@"<div><br></div>");` ...to right after we create the source WKWebView in `auto source = webViewForEditActionTesting();`.
Wenson Hsieh
Comment 4 2018-11-14 10:21:34 PST
Created attachment 354828 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-11-14 11:00:13 PST
Comment on attachment 354828 [details] Patch for landing Clearing flags on attachment: 354828 Committed r238186: <https://trac.webkit.org/changeset/238186>
Note You need to log in before you can comment on or make changes to this bug.