Summary: | WebKit.ApplicationManifestBasic API test is failing when enabling PSON | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, beidson, ggaren, rniwa, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 191572 | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2018-11-13 14:56:41 PST
Created attachment 354716 [details]
WIP Patch
Created attachment 354720 [details]
Patch
Created attachment 354749 [details]
Patch
Comment on attachment 354749 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354749&action=review > Source/WebKit/UIProcess/API/APINavigation.h:159 > + std::optional<SubstituteData> m_substituteData; Since it is uncommon it might be a little better to use std::unique_ptr so we don't have to always use the memory of the whole structure. > Source/WebKit/UIProcess/WebNavigationState.h:54 > + Ref<API::Navigation> createLoadDataNavigation(const IPC::DataReference&, const String& MIMEType, const String& encoding, const String& baseURL, API::Object* userData); We already have a struct. Couldn't we just add one parameter here? Created attachment 354814 [details]
Patch
Comment on attachment 354814 [details] Patch Clearing flags on attachment: 354814 Committed r238179: <https://trac.webkit.org/changeset/238179> All reviewed patches have been landed. Closing bug. |