Bug 191580

Summary: Remove WebKitTestRunnerLib's build warnings.
Product: WebKit Reporter: Takashi Komori <takashi.komori>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fujii.hironori, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Takashi Komori
Reported 2018-11-13 00:45:59 PST
Remove WebKitTestRunnerLib's build warnings. Building WebKitTestRunnerLib for WinCairo produces many redefinition warnings. This is because wtf/Platform.h is included ahead cmakeconfig.h, through precompiled header (WebKitTestRunnerPrefix.h) To remove these warnings we should include cmakeconfig.h in WebKitTestRunnerPrefix.h
Attachments
Patch (1.18 KB, patch)
2018-11-13 00:56 PST, Takashi Komori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Komori
Comment 1 2018-11-13 00:56:30 PST
Created attachment 354659 [details] Patch
WebKit Commit Bot
Comment 2 2018-11-13 02:05:24 PST
Comment on attachment 354659 [details] Patch Clearing flags on attachment: 354659 Committed r238127: <https://trac.webkit.org/changeset/238127>
WebKit Commit Bot
Comment 3 2018-11-13 02:05:25 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-11-13 02:06:25 PST
<rdar://problem/46022189>
Note You need to log in before you can comment on or make changes to this bug.