Bug 191575

Summary: Web Inspector: Styles: shift-clicking on a property should extend selection
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 191435    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
[Animated GIF] With patch applied
none
Patch
none
Patch
none
Patch
hi: review+
Patch none

Nikita Vasilyev
Reported 2018-11-12 18:22:59 PST
When there's at least one property is selected, shift-clicking another property of the same rule should extend the selection. This behavior should be similar to the one in macOS Finder.
Attachments
Patch (11.13 KB, patch)
2018-11-12 18:36 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Animated GIF] With patch applied (72.44 KB, image/gif)
2018-11-12 18:38 PST, Nikita Vasilyev 		no flags
Details
Patch (11.29 KB, patch)
2018-11-13 13:59 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (11.77 KB, patch)
2018-11-13 16:27 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (11.70 KB, patch)
2018-11-13 17:17 PST, Nikita Vasilyev 		hi: review+
DetailsFormatted DiffDiff
Patch (11.79 KB, patch)
2018-11-14 14:12 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-12 18:23:20 PST
<rdar://problem/46012855>
Nikita Vasilyev
Comment 2 2018-11-12 18:36:52 PST
Created attachment 354619 [details] Patch
Nikita Vasilyev
Comment 3 2018-11-12 18:38:11 PST
Created attachment 354620 [details] [Animated GIF] With patch applied
Nikita Vasilyev
Comment 4 2018-11-12 18:41:21 PST
This doesn't patch depends on Bug 191435 - Web Inspector: Styles: Command-A should select all properties. It doesn't apply to master.
Nikita Vasilyev
Comment 5 2018-11-13 13:59:09 PST
Created attachment 354700 [details] Patch
Nikita Vasilyev
Comment 6 2018-11-13 16:27:37 PST
Created attachment 354725 [details] Patch I implemented Shift-ArrowUp/ArrowDown keys, too. It was only two lines of code :)
Nikita Vasilyev
Comment 7 2018-11-13 17:17:56 PST
Created attachment 354732 [details] Patch Fix assertions.
Nikita Vasilyev
Comment 8 2018-11-13 17:22:49 PST
*** Bug 191125 has been marked as a duplicate of this bug. ***
Devin Rousso
Comment 9 2018-11-14 13:42:05 PST
Comment on attachment 354732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354732&action=review r=me, with some design feedback/changes > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:57 > + set focusIndex(value) It seems odd that setting the `focusIndex` would automatically select something. I'd rather you extend/rework `selectProperties` to assume `_anchorIndex` when not supplied, or just provide a way for callers to access `_anchorIndex`. > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:476 > + window.addEventListener("click", this._handleWindowMouseUp.bind(this), {capture: true, once: true}); Please rename this to `_handleWindowClick`
Nikita Vasilyev
Comment 10 2018-11-14 14:12:01 PST
Created attachment 354851 [details] Patch
WebKit Commit Bot
Comment 11 2018-11-14 14:28:59 PST
Comment on attachment 354851 [details] Patch Clearing flags on attachment: 354851 Committed r238201: <https://trac.webkit.org/changeset/238201>
WebKit Commit Bot
Comment 12 2018-11-14 14:29:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.