Bug 191560

Summary: Web Inspector: REGRESSION(r236540): Debugger: breakpoints are sorted alphabetically instead of numerically
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 182406    
Bug Blocks:    
Attachments:
Description Flags
[Image] Screenshot of Issue
none
Patch
none
[Image] Unable to reproduce
none
[Image] Unable to reproduce (non-prettyprinted source) none

Devin Rousso
Reported 2018-11-12 13:28:51 PST
.
Attachments
[Image] Screenshot of Issue (39.29 KB, image/png)
2018-11-12 13:29 PST, Devin Rousso 		no flags
Details
Patch (3.60 KB, patch)
2018-11-12 13:33 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] Unable to reproduce (125.27 KB, image/png)
2018-11-12 13:41 PST, Matt Baker 		no flags
Details
[Image] Unable to reproduce (non-prettyprinted source) (143.18 KB, image/png)
2018-11-12 13:45 PST, Matt Baker 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-11-12 13:29:14 PST
Created attachment 354584 [details] [Image] Screenshot of Issue
Devin Rousso
Comment 2 2018-11-12 13:33:35 PST
Created attachment 354586 [details] Patch
Matt Baker
Comment 3 2018-11-12 13:41:19 PST
Created attachment 354588 [details] [Image] Unable to reproduce They appear sorted numerically to me. I wonder what the difference is.
Matt Baker
Comment 4 2018-11-12 13:45:06 PST
Created attachment 354589 [details] [Image] Unable to reproduce (non-prettyprinted source)
Devin Rousso
Comment 5 2018-11-12 13:51:28 PST
(In reply to Matt Baker from comment #3) > They appear sorted numerically to me. I wonder what the difference is. Try setting a breakpoint on a line > 1000. I think the "," is what's tripping up the sorting.
Joseph Pecoraro
Comment 6 2018-11-12 13:53:40 PST
Comment on attachment 354586 [details] Patch r=me
WebKit Commit Bot
Comment 7 2018-11-14 14:39:33 PST
Comment on attachment 354586 [details] Patch Clearing flags on attachment: 354586 Committed r238202: <https://trac.webkit.org/changeset/238202>
WebKit Commit Bot
Comment 8 2018-11-14 14:39:34 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-11-14 14:40:58 PST
<rdar://problem/46075952>
Note You need to log in before you can comment on or make changes to this bug.