Summary: | Web Inspector: Canvas: don't start with auto-capture enabled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 190856 | ||||||||
Bug Blocks: | 173807, 175485 | ||||||||
Attachments: |
|
Description
Devin Rousso
2018-11-12 10:45:53 PST
Created attachment 354569 [details]
Patch
Comment on attachment 354569 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354569&action=review r=me > Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js:226 > this._recordingAutoCaptureFrameCountInputElement.style.setProperty("width", (textMetrics.width + 8) + "px"); Out of curiosity, where does the 8px come from? It looks like it comes from canvasOverviewContentView.css:184: .navigation-bar > .item.canvas-recording-auto-capture > label > input { width: 1.5em; min-width: 1.5em; margin: 0 4px; text-align: center; } If so this should be a const, with a comment warning to keep it in sync with the stylesheet. I know this is off topic for this patch, but I noticed it while reading the file for context. Created attachment 354791 [details]
Patch
Comment on attachment 354791 [details] Patch Clearing flags on attachment: 354791 Committed r238169: <https://trac.webkit.org/changeset/238169> All reviewed patches have been landed. Closing bug. |