Summary: | [WebAuthN] Store necessary authenticator info into HID authenticators | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, alex.gaynor, bfulgham, cdumez, jiewen_tan, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 181943 | ||||||
Attachments: |
|
Description
Jiewen Tan
2018-11-11 18:06:58 PST
Created attachment 354784 [details]
Patch
Comment on attachment 354784 [details]
Patch
I guess I don't need any review for this one. I will land an unreviewed patch on my own.
Comment on attachment 354784 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354784&action=review > Source/WebKit/ChangeLog:8 > + Somehow this is fixed by r238166. Some very minor improvment over it. typo: improvment "Somehow"? You don't know how? I personally find this changelog confusing. (In reply to Chris Dumez from comment #3) > Comment on attachment 354784 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354784&action=review > > > Source/WebKit/ChangeLog:8 > > + Somehow this is fixed by r238166. Some very minor improvment over it. > > typo: improvment > > "Somehow"? You don't know how? I personally find this changelog confusing. I thought I was working on a branch for this change, and I didn't. Therefore I actually made this change in: Committed r238166: <https://trac.webkit.org/changeset/238166>. The change is actually simple as well. Which I just move the AuthenticatorGetInfoResponse to the CtapHidAuthenticator after we have the response. And use the userVerificationAvailability info when issuing requests to authenticators in CtapHidAuthenticator. Committed r238247: <https://trac.webkit.org/changeset/238247> Comment on attachment 354784 [details]
Patch
This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.
|