Summary: | [WebAuthN] PublicKeyCredentialCreationOptions::AuthenticatorSelectionCriteria::AuthenticatorAttachment should be optional | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
Component: | WebCore Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, alex.gaynor, bfulgham, cdumez, commit-queue, jiewen_tan, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 181943 | ||||||
Attachments: |
|
Description
Jiewen Tan
2018-11-11 17:56:29 PST
Created attachment 354777 [details]
Patch
Comment on attachment 354777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354777&action=review > Source/WebCore/ChangeLog:11 > + Covered by existing tests. Is there an observable change in behavior from this change? Comment on attachment 354777 [details]
Patch
Looks good. I assume there's no WPT for this, or you would have unskipped it.
Comment on attachment 354777 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354777&action=review Thanks Brent for r+ this patch. >> Source/WebCore/ChangeLog:11 >> + Covered by existing tests. > > Is there an observable change in behavior from this change? Things are a little bit tricky here. There is currently no way of testing the wrong(before) behavior as we only support one kind of authenticators in macOS currently. That means we get the same response if authenticatorAttachment = std::nullopt or CrossPlatform. Comment on attachment 354777 [details] Patch Clearing flags on attachment: 354777 Committed r238240: <https://trac.webkit.org/changeset/238240> All reviewed patches have been landed. Closing bug. |