Bug 191510

Summary: Web Inspector: Styles: Pressing Tab or Enter should start editing focused property
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
[animated GIF] With patch applied
none
Patch none

Nikita Vasilyev
Reported 2018-11-10 17:44:40 PST
When one or more properties are selected, pressing Tab or Enter key should start editing the first selected property. Disabled (commented out) properties cannot be edited, so when the first selected property is disabled find the next enabled property and edit it instead.
Attachments
Patch (2.02 KB, patch)
2018-11-10 17:47 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[animated GIF] With patch applied (87.46 KB, image/gif)
2018-11-10 17:49 PST, Nikita Vasilyev 		no flags
Details
Patch (1.79 KB, patch)
2018-11-11 20:08 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-10 17:45:01 PST
<rdar://problem/45970897>
Nikita Vasilyev
Comment 2 2018-11-10 17:47:26 PST
Created attachment 354486 [details] Patch
Nikita Vasilyev
Comment 3 2018-11-10 17:49:47 PST
Created attachment 354487 [details] [animated GIF] With patch applied
Devin Rousso
Comment 4 2018-11-11 17:19:44 PST
Comment on attachment 354486 [details] Patch I would expect it to edit the selected property (e.g. the one with the left "selection" border), not the first property. Other than that, looks good.
Nikita Vasilyev
Comment 5 2018-11-11 20:08:11 PST
Created attachment 354529 [details] Patch
Devin Rousso
Comment 6 2018-11-12 10:09:18 PST
Comment on attachment 354529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354529&action=review > Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:515 > + if (property && property.enabled) { We could probably be a little "smart" here and try to find the first property after (or before if there are none after) that is `enabled`.
WebKit Commit Bot
Comment 7 2018-11-12 10:09:32 PST
Comment on attachment 354529 [details] Patch Clearing flags on attachment: 354529 Committed r238096: <https://trac.webkit.org/changeset/238096>
WebKit Commit Bot
Comment 8 2018-11-12 10:09:34 PST
All reviewed patches have been landed. Closing bug.
Nikita Vasilyev
Comment 9 2018-11-13 13:46:05 PST
*** Bug 191135 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.