Bug 191509

Summary: [LFC][IFC] Construct dedicated runs when the inline element requires it.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch koivisto: review+

alan
Reported 2018-11-10 17:36:34 PST
When a run overlaps multiple inline elements like this: <span>normal text content</span><span style="position: relative; left: 10px;">but this one needs dedicated run</span><span>end of text</span> The above content generates one long run <normal text contentbut this one needs dedicated runend of text> However the middle run needs to be moved independently from the rest of the content, hence it needs a dedicated inline run.
Attachments
Patch (16.48 KB, patch)
2018-11-10 18:10 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (16.48 KB, patch)
2018-11-10 20:50 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (16.86 KB, patch)
2018-11-11 21:50 PST, alan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-11-10 18:10:23 PST
Created attachment 354488 [details] Patch
alan
Comment 2 2018-11-10 20:50:58 PST
Created attachment 354494 [details] Patch
alan
Comment 3 2018-11-11 21:50:18 PST
Created attachment 354532 [details] Patch
alan
Comment 4 2018-11-11 21:51:14 PST
This is not supposed to be too common, but could improve if it ends up being in a hot codepath.
Antti Koivisto
Comment 5 2018-11-12 07:48:41 PST
Comment on attachment 354532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354532&action=review > Source/WebCore/ChangeLog:10 > + <span>normal text content</span><span style="position: relative; left: 10px;">but this one needs a dedicated run</span><span>end of text</span> No test?
alan
Comment 6 2018-11-12 08:18:16 PST
Committed r238087: <https://trac.webkit.org/changeset/238087>
Radar WebKit Bug Importer
Comment 7 2018-11-12 08:19:25 PST
<rdar://problem/45990074>
alan
Comment 8 2018-11-12 08:21:07 PST
(In reply to Antti Koivisto from comment #5) > Comment on attachment 354532 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354532&action=review > > > Source/WebCore/ChangeLog:10 > > + <span>normal text content</span><span style="position: relative; left: 10px;">but this one needs a dedicated run</span><span>end of text</span> > > No test? The positioning part is not done yet. This patch was actually in preparation for that (have to split the runs in order to move them independently)
Note You need to log in before you can comment on or make changes to this bug.