Bug 191505

Summary: Require <iframe allow="display"> for an iframe to use getDisplayMedia
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, jer.noble, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Patch
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Patch
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Patch none

Eric Carlson
Reported 2018-11-10 10:52:29 PST
'display' was recently added to the permissions spec for screen capture (https://github.com/w3c/permissions/pull/184). Require <iframe allow="display"> for an iframe to use getDisplayMedia.
Attachments
Patch (15.37 KB, patch)
2018-11-10 10:59 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (20.30 KB, patch)
2018-11-10 11:56 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.02 MB, application/zip)
2018-11-10 13:13 PST, EWS Watchlist 		no flags
Details
Patch (20.53 KB, patch)
2018-11-11 16:56 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.93 MB, application/zip)
2018-11-11 18:08 PST, EWS Watchlist 		no flags
Details
Patch (20.95 KB, patch)
2018-11-12 06:25 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.03 MB, application/zip)
2018-11-12 07:16 PST, EWS Watchlist 		no flags
Details
Patch (21.60 KB, patch)
2018-11-12 07:55 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-10 10:52:54 PST
<rdar://problem/45968811>
Eric Carlson
Comment 2 2018-11-10 10:59:52 PST
Created attachment 354463 [details] Patch
Eric Carlson
Comment 3 2018-11-10 11:56:07 PST
Created attachment 354468 [details] Patch
EWS Watchlist
Comment 4 2018-11-10 13:13:18 PST
Comment on attachment 354468 [details] Patch Attachment 354468 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9941440 New failing tests: http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html
EWS Watchlist
Comment 5 2018-11-10 13:13:20 PST
Created attachment 354473 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Eric Carlson
Comment 6 2018-11-11 16:56:08 PST
Created attachment 354517 [details] Patch
EWS Watchlist
Comment 7 2018-11-11 18:08:52 PST
Comment on attachment 354517 [details] Patch Attachment 354517 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9952769 New failing tests: http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html
EWS Watchlist
Comment 8 2018-11-11 18:08:54 PST
Created attachment 354521 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Eric Carlson
Comment 9 2018-11-12 06:25:24 PST
Created attachment 354554 [details] Patch
EWS Watchlist
Comment 10 2018-11-12 07:16:04 PST
Comment on attachment 354554 [details] Patch Attachment 354554 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9958042 New failing tests: http/tests/media/media-stream/get-display-media-iframe-allow-attribute.html
EWS Watchlist
Comment 11 2018-11-12 07:16:06 PST
Created attachment 354557 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Eric Carlson
Comment 12 2018-11-12 07:55:23 PST
Created attachment 354558 [details] Patch
WebKit Commit Bot
Comment 13 2018-11-12 09:18:58 PST
Comment on attachment 354558 [details] Patch Clearing flags on attachment: 354558 Committed r238091: <https://trac.webkit.org/changeset/238091>
WebKit Commit Bot
Comment 14 2018-11-12 09:19:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.