Bug 191488

Summary: Suspended page persists even after back/forward list item is gone
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2018-11-09 14:55:38 PST 
Suspended page persists even after back/forward list item is gone.
Comment 1 Chris Dumez 2018-11-09 14:55:54 PST 
<rdar://problem/45953006>
Comment 2 Chris Dumez 2018-11-09 15:02:06 PST 
Created attachment 354393 [details]
Patch
Comment 3 Geoffrey Garen 2018-11-09 15:08:49 PST 
Comment on attachment 354393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354393&action=review

> Source/WebKit/Shared/WebBackForwardListItem.cpp:129
> +void WebBackForwardListItem::suspendedPageIsNoLongerNeeded()

I would call this removeSuspendedPageFromProcessPool.

> Source/WebKit/UIProcess/WebProcessPool.cpp:2273
> +void WebProcessPool::removeSuspendedPageProxy(SuspendedPageProxy& suspendedPage)

I would call this removeSuspendedPage.
Comment 4 Geoffrey Garen 2018-11-09 15:09:14 PST 
Comment on attachment 354393 [details]
Patch

r=me
Comment 5 Chris Dumez 2018-11-09 15:47:35 PST 
Created attachment 354399 [details]
Patch
Comment 6 WebKit Commit Bot 2018-11-09 16:24:16 PST 
Comment on attachment 354399 [details]
Patch

Clearing flags on attachment: 354399

Committed r238061: <https://trac.webkit.org/changeset/238061>
Comment 7 WebKit Commit Bot 2018-11-09 16:24:17 PST 
All reviewed patches have been landed.  Closing bug.