Bug 191475

Summary:

[iOS] WebKit should handle shift state changes when using the software keyboard

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit Misc.

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, dino, ews-watchlist, megan_gardner, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

iPhone / iPad

OS:

iOS 12

URL:

https://unixpapa.com/js/testkey.html

Bug Depends on:

Bug Blocks:

190571, 190565

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none

Daniel Bates

Reported 2018-11-09 10:56:13 PST

Tapping the shift key on the software keyboard should dispatch DOM key events. Double tapping the shift key on the software keyboard to toggle caps locks should show the caps locks indicator if the currently focused element is a password field.

Attachments
Patch (14.98 KB, patch) 2018-12-18 16:04 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.43 MB, application/zip) 2018-12-18 18:06 PST, EWS Watchlist	no flags	Details
Patch (14.42 KB, patch) 2019-01-04 16:52 PST, Daniel Bates	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.44 MB, application/zip) 2019-01-04 18:47 PST, EWS Watchlist	no flags	Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2018-11-09 11:00:13 PST

You can observe this issue by performing the following: 1. Visit <https://unixpapa.com/js/testkey.html>. 2. Check the modifiers checkbox. 3. Focus the text field. 4. Tap the shift key on the software keyboard. Nothing happens. But we should have seen a keydown and keyup event for the shift key. Similarly, nothing happens if you enable caps lock or disable caps lock by double tapping the shift key.

Radar WebKit Bug Importer

Comment 2 2018-11-09 11:01:36 PST

<rdar://problem/45949246>

Daniel Bates

Comment 3 2018-12-18 16:04:09 PST

Created attachment 357627 [details] Patch It is not possible to write a test for this change with our current infrastructure without mocking more of the software keyboard or performing user interface testing. I am open to ideas.

EWS Watchlist

Comment 4 2018-12-18 18:06:54 PST

Comment on attachment 357627 [details] Patch Attachment 357627 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10466513 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

EWS Watchlist

Comment 5 2018-12-18 18:06:56 PST

Created attachment 357644 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Brent Fulgham

Comment 6 2019-01-04 12:57:37 PST

Comment on attachment 357644 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 This EWS failure is not related to this patch. I've seen it happen on other patches as well.

Daniel Bates

Comment 7 2019-01-04 16:52:30 PST

Created attachment 358396 [details] Patch

EWS Watchlist

Comment 8 2019-01-04 18:47:24 PST

Comment on attachment 358396 [details] Patch Attachment 358396 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10635430 New failing tests: imported/w3c/web-platform-tests/webrtc/simplecall.https.html

EWS Watchlist

Comment 9 2019-01-04 18:47:26 PST

Created attachment 358418 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Daniel Bates

Comment 10 2019-01-22 13:15:43 PST

Comment on attachment 358396 [details] Patch Clearing flags on attachment: 358396 Committed r240288: <https://trac.webkit.org/changeset/240288>

Daniel Bates

Comment 11 2019-01-22 13:15:44 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.