Bug 191471

Summary: [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, mitz, rniwa, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Depends on webkit.org/b/191410
none
Depends on webkit.org/b/191410
none
Rebase on trunk
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2018-11-09 09:18:33 PST
-_increaseListLevel: and -_decreaseListLevel:
Attachments
Depends on webkit.org/b/191410 (52.86 KB, patch)
2018-11-09 09:23 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Depends on webkit.org/b/191410 (7.23 KB, patch)
2018-11-09 09:24 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rebase on trunk (7.46 KB, patch)
2018-11-09 12:27 PST, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (7.32 KB, patch)
2018-11-09 14:14 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-11-09 09:23:18 PST
Created attachment 354349 [details] Depends on webkit.org/b/191410
Wenson Hsieh
Comment 2 2018-11-09 09:24:00 PST
Created attachment 354350 [details] Depends on webkit.org/b/191410
Wenson Hsieh
Comment 3 2018-11-09 12:25:53 PST
<rdar://problem/45952472>
Wenson Hsieh
Comment 4 2018-11-09 12:27:36 PST
Created attachment 354372 [details] Rebase on trunk
Wenson Hsieh
Comment 5 2018-11-09 12:33:25 PST
Comment on attachment 354372 [details] Rebase on trunk View in context: https://bugs.webkit.org/attachment.cgi?id=354372&action=review Thanks for the review! > Source/WebKit/ChangeLog:16 > +2018-11-08 Wenson Hsieh <wenson_hsieh@apple.com> Oops, it looks like I stomped over this ChangeLog date :P Will fix before landing. > Tools/ChangeLog:15 > +2018-11-08 Wenson Hsieh <wenson_hsieh@apple.com> (This date too)
Wenson Hsieh
Comment 6 2018-11-09 14:14:13 PST
Created attachment 354385 [details] Patch for landing
WebKit Commit Bot
Comment 7 2018-11-09 14:50:57 PST
Comment on attachment 354385 [details] Patch for landing Clearing flags on attachment: 354385 Committed r238057: <https://trac.webkit.org/changeset/238057>
Note You need to log in before you can comment on or make changes to this bug.