Summary: | [css-grid] Dynamically setting "position: absolute" in a grid item doesn't trigger a relayout of that element | ||
---|---|---|---|
Product: | WebKit | Reporter: | Javier Fernandez <jfernandez> |
Component: | Layout and Rendering | Assignee: | Javier Fernandez <jfernandez> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, obrufau, pdr, rego, rniwa, simon.fraser, svillar, webkit-bug-importer, zalan |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Created attachment 354331 [details]
Patch
Comment on attachment 354331 [details]
Patch
r=me
Comment on attachment 354331 [details] Patch Attachment 354331 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9922961 New failing tests: imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html Created attachment 354333 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 354331 [details] Patch Attachment 354331 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9922975 New failing tests: imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html Created attachment 354335 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 354331 [details] Patch Attachment 354331 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9923108 New failing tests: imported/w3c/web-platform-tests/css/css-grid/abspos/grid-item-absolute-positioning-dynamic-001.html imported/w3c/web-platform-tests/css/css-grid/abspos/absolute-positioning-changing-containing-block-001.html Created attachment 354340 [details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Mmmm, dunno why this patch never landed... we might want to review it again at some poing. The patch seems fine, just needs a rebase. Created attachment 400757 [details]
Patch rebased
(In reply to Javier Fernandez from comment #11) > Created attachment 400757 [details] > Patch rebased It seems the patch is not rebased yet. Created attachment 400820 [details]
Rebased again
Comment on attachment 400820 [details]
Rebased again
r=me
Committed r262481: <https://trac.webkit.org/changeset/262481> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400820 [details]. |
Created attachment 354329 [details] Test case to reproduce the issue Check the attached example, you shouldn't see red as the item gets absolute positioned and should take the whole size of the grid. Note that in the example, when "item" is marked as absolutely positioned, its containing block is "wrapper" and not the grid container. For some reason we're not triggering a new layout of the "item" in this situation.