Bug 191449

Summary: Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, eric.carlson, jer.noble, jonlee, megan_gardner, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Tim Horton
Reported 2018-11-08 18:11:06 PST
Make use of _UIRemoteView instead of CALayerHost if possible for WKRemoteView
Attachments
Patch (5.20 KB, patch)
2018-11-08 18:16 PST, Tim Horton
eric.carlson: review+
Tim Horton
Comment 1 2018-11-08 18:16:03 PST
Tim Horton
Comment 2 2018-11-08 18:16:05 PST
Eric Carlson
Comment 3 2018-11-09 09:00:11 PST
Comment on attachment 354299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354299&action=review > Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:189 > + std::call_once(initializeCanUseUIRemoteView, [] { > + canUseUIRemoteView = [_UIRemoteView instancesRespondToSelector:@selector(initWithFrame:pid:contextID:)]; > + }); Nit: this indentation is odd, although the style-bot didn't complain and it is usually much more picky than I am.
Tim Horton
Comment 4 2018-11-09 10:55:33 PST
Comment on attachment 354299 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354299&action=review >> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:189 >> + }); > > Nit: this indentation is odd, although the style-bot didn't complain and it is usually much more picky than I am. That is really weird. Also not sure how it happened. Thank you for your review!
Tim Horton
Comment 5 2018-11-09 10:58:56 PST
Note You need to log in before you can comment on or make changes to this bug.