Bug 191422

Summary:

Remove unnecessary bindArguments() in resetting statement of IDB cursor

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

New Bugs

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

achristensen, alecflett, beidson, ews-watchlist, jsbell, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews203 for win-future	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Archive of layout-test-results from ews113 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none

Sihui Liu

Reported 2018-11-08 09:07:09 PST

Redundant bindArguments() noticed

Attachments
Patch (1.39 KB, patch) 2018-11-08 09:10 PST, Sihui Liu	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-sierra (2.72 MB, application/zip) 2018-11-08 10:15 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews203 for win-future (12.94 MB, application/zip) 2018-11-08 11:06 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (9.41 MB, application/zip) 2018-11-08 11:07 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-sierra (3.45 MB, application/zip) 2018-11-08 11:12 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.25 MB, application/zip) 2018-11-08 12:29 PST, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Sihui Liu

Comment 1 2018-11-08 09:09:27 PST

resetAndRebindStatement() calls establishStatement() establishStatement() calls createSQLiteStatement() createSQLiteStatement() calls bindArguments() So we don't need to call bindArguments() additionally in resetAndRebindStatement().

Sihui Liu

Comment 2 2018-11-08 09:10:47 PST

Created attachment 354243 [details] Patch

EWS Watchlist

Comment 3 2018-11-08 10:15:02 PST

Comment on attachment 354243 [details] Patch Attachment 354243 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9910386 New failing tests: storage/indexeddb/cursor-update-while-iterating.html storage/indexeddb/modern/index-cursor-3.html storage/indexeddb/cursor-continue-validity.html storage/indexeddb/cursor-added-bug.html storage/indexeddb/cursor-update.html storage/indexeddb/cursor-skip-deleted.html imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm imported/w3c/web-platform-tests/IndexedDB/idbcursor-iterating-update.htm

EWS Watchlist

Comment 4 2018-11-08 10:15:04 PST

Created attachment 354247 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-11-08 11:06:23 PST

Comment on attachment 354243 [details] Patch Attachment 354243 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9910671 New failing tests: storage/indexeddb/cursor-update-while-iterating.html storage/indexeddb/modern/index-cursor-3.html storage/indexeddb/cursor-continue-validity.html storage/indexeddb/cursor-added-bug.html storage/indexeddb/cursor-update.html storage/indexeddb/cursor-skip-deleted.html

EWS Watchlist

Comment 6 2018-11-08 11:06:39 PST

Created attachment 354252 [details] Archive of layout-test-results from ews203 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews203 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

EWS Watchlist

Comment 7 2018-11-08 11:07:34 PST

Comment on attachment 354243 [details] Patch Attachment 354243 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9910500 New failing tests: storage/indexeddb/cursor-update-while-iterating.html storage/indexeddb/modern/index-cursor-3.html storage/indexeddb/cursor-continue-validity.html imported/w3c/web-platform-tests/IndexedDB/idbcursor-iterating-update.htm storage/indexeddb/cursor-update.html storage/indexeddb/cursor-skip-deleted.html imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm storage/indexeddb/cursor-added-bug.html

EWS Watchlist

Comment 8 2018-11-08 11:07:36 PST

Created attachment 354253 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 9 2018-11-08 11:12:33 PST

Comment on attachment 354243 [details] Patch Attachment 354243 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9910535 New failing tests: storage/indexeddb/cursor-update-while-iterating.html storage/indexeddb/modern/index-cursor-3.html storage/indexeddb/cursor-continue-validity.html storage/indexeddb/cursor-added-bug.html storage/indexeddb/cursor-skip-deleted.html imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm imported/w3c/web-platform-tests/IndexedDB/idbcursor-iterating-update.htm

EWS Watchlist

Comment 10 2018-11-08 11:12:35 PST

Created attachment 354255 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 11 2018-11-08 12:29:48 PST

Comment on attachment 354243 [details] Patch Attachment 354243 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9911617 New failing tests: storage/indexeddb/cursor-update-while-iterating.html storage/indexeddb/modern/index-cursor-3.html storage/indexeddb/cursor-continue-validity.html storage/indexeddb/cursor-added-bug.html storage/indexeddb/cursor-skip-deleted.html imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm imported/w3c/web-platform-tests/IndexedDB/idbcursor-iterating-update.htm

EWS Watchlist

Comment 12 2018-11-08 12:29:49 PST

Created attachment 354262 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Alex Christensen

Comment 13 2021-11-01 12:47:13 PDT

Comment on attachment 354243 [details] Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review.

Note You need to log in before you can comment on or make changes to this bug.