Bug 191421

Summary:

[Flatpak] Refactoring and drive-by fixes

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Tools / Tests

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dbates, ews-watchlist, lforschler, mcatanzaro, tsaunier, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	mcatanzaro: review+

Philippe Normand

Reported 2018-11-08 08:21:39 PST

Attachments
Patch (26.92 KB, patch) 2018-11-08 08:45 PST, Philippe Normand	no flags	Details Formatted Diff Diff
Patch (26.93 KB, patch) 2018-11-08 08:50 PST, Philippe Normand	no flags	Details Formatted Diff Diff
Patch (27.65 KB, patch) 2018-11-08 09:34 PST, Philippe Normand	mcatanzaro: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2018-11-08 08:45:15 PST

Created attachment 354241 [details] Patch

Philippe Normand

Comment 2 2018-11-08 08:50:37 PST

Created attachment 354242 [details] Patch

Thibault Saunier

Comment 3 2018-11-08 09:07:04 PST

Comment on attachment 354242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354242&action=review Loogs good otherwise. > Tools/flatpak/flatpakutils.py:722 > + env_vars.update(extra_env_vars) Don't you want extra_env_vars to be forward no matter what? Here you will forward then only if they match `env_var_prefixes_to_keep` or `env_var_prefixes_to_keep` afaict.

Philippe Normand

Comment 4 2018-11-08 09:17:37 PST

Comment on attachment 354242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354242&action=review >> Tools/flatpak/flatpakutils.py:722 >> + env_vars.update(extra_env_vars) > > Don't you want extra_env_vars to be forward no matter what? Here you will forward then only if they match `env_var_prefixes_to_keep` or `env_var_prefixes_to_keep` afaict. Only if they match `env_var_prefixes_to_keep`. I have another patch for later that makes use of that feature, adding a new env var in `env_var_prefixes_to_keep` :)

Philippe Normand

Comment 5 2018-11-08 09:18:49 PST

Comment on attachment 354242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354242&action=review >>> Tools/flatpak/flatpakutils.py:722 >>> + env_vars.update(extra_env_vars) >> >> Don't you want extra_env_vars to be forward no matter what? Here you will forward then only if they match `env_var_prefixes_to_keep` or `env_var_prefixes_to_keep` afaict. > > Only if they match `env_var_prefixes_to_keep`. I have another patch for later that makes use of that feature, adding a new env var in `env_var_prefixes_to_keep` :) Sorry, I meant `env_vars_to_keep` instead of `env_var_prefixes_to_keep`

Philippe Normand

Comment 6 2018-11-08 09:34:35 PST

Created attachment 354244 [details] Patch

Philippe Normand

Comment 7 2018-11-09 02:54:00 PST

Committed r238025: <https://trac.webkit.org/changeset/238025>

Radar WebKit Bug Importer

Comment 8 2018-11-09 02:54:23 PST

<rdar://problem/45939618>

Note You need to log in before you can comment on or make changes to this bug.