Bug 191410

Summary:

[Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit2

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bdakin, commit-queue, dino, mitz, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Fix some typos.	dino: review+, commit-queue: commit-queue-
Patch for landing	none

Description Wenson Hsieh 2018-11-07 19:17:59 PST

This would make it easier for Mail to implement list editing behaviors using WebKit2.

Comment 1 Wenson Hsieh 2018-11-07 19:18:20 PST

<rdar://problem/45898610>

Comment 2 Wenson Hsieh 2018-11-08 19:34:08 PST

Created attachment 354304 [details]
Patch

Comment 3 Wenson Hsieh 2018-11-08 20:19:42 PST

> In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos/DerivedSources/WebKit2/unified-sources/UnifiedSource29.cpp:3:
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/WebPageProxy.cpp:1762:44: error: no member named 'IncreaseListLevel' in namespace 'Messages::WebPage'
>         m_process->send(Messages::WebPage::IncreaseListLevel(), m_pageID);
>                         ~~~~~~~~~~~~~~~~~~~^
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/WebPageProxy.cpp:1768:44: error: no member named 'DecreaseListLevel' in namespace 'Messages::WebPage'
>         m_process->send(Messages::WebPage::DecreaseListLevel(), m_pageID);
>                         ~~~~~~~~~~~~~~~~~~~^
> /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/WebPageProxy.cpp:1774:44: error: no member named 'ChangeListType' in namespace 'Messages::WebPage'
>         m_process->send(Messages::WebPage::ChangeListType(), m_pageID);
>                         ~~~~~~~~~~~~~~~~~~~^
> 3 errors generated.

It's not terribly clear to me why the iOS device build is failing, whereas iOS sim builds.

Comment 4 Wenson Hsieh 2018-11-08 20:44:08 PST

Created attachment 354308 [details]
Fix some typos.

Comment 5 WebKit Commit Bot 2018-11-09 11:32:16 PST Comment hidden (obsolete)

Comment on attachment 354308 [details]
Fix some typos.

Rejecting attachment 354308 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 354308, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog is not at the top of the file.

Full output: https://webkit-queues.webkit.org/results/9926409

Comment 6 Wenson Hsieh 2018-11-09 11:37:25 PST

Created attachment 354361 [details]
Patch for landing

Comment 7 WebKit Commit Bot 2018-11-09 12:16:42 PST

Comment on attachment 354361 [details]
Patch for landing

Clearing flags on attachment: 354361

Committed r238050: <https://trac.webkit.org/changeset/238050>