Bug 191405

Summary: REGRESSION(r236705): Web Inspector: wrong text color for selected DataGrid row
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Bug
none
Patch
none
[Screen recording] Bug
none
Patch none

Nikita Vasilyev
Reported 2018-11-07 16:02:32 PST
Created attachment 354174 [details] [Image] Bug For both Dark Mode mode and Light Mode, the text color should be white. Regressed in https://trac.webkit.org/changeset/236705/webkit#file5
Attachments
[Image] Bug (51.58 KB, image/png)
2018-11-07 16:02 PST, Nikita Vasilyev 		no flags
Details
Patch (1.48 KB, patch)
2018-11-07 16:07 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Screen recording] Bug (5.13 MB, video/quicktime)
2018-11-07 16:34 PST, Nikita Vasilyev 		no flags
Details
Patch (1.51 KB, patch)
2018-11-07 17:20 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-11-07 16:03:36 PST
<rdar://problem/45893283>
Nikita Vasilyev
Comment 2 2018-11-07 16:07:00 PST
Created attachment 354175 [details] Patch
Nikita Vasilyev
Comment 3 2018-11-07 16:34:46 PST
Created attachment 354179 [details] [Screen recording] Bug
Matt Baker
Comment 4 2018-11-07 17:06:10 PST
Comment on attachment 354175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354175&action=review > Source/WebInspectorUI/UserInterface/Views/DataGrid.css:429 > + color: white; Should this just be `color: var(--selected-text-color);`?
Nikita Vasilyev
Comment 5 2018-11-07 17:11:48 PST
(In reply to Matt Baker from comment #4) > Comment on attachment 354175 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354175&action=review > > > Source/WebInspectorUI/UserInterface/Views/DataGrid.css:429 > > + color: white; > > Should this just be `color: var(--selected-text-color);`? --selected-foreground-color, yes.
Nikita Vasilyev
Comment 6 2018-11-07 17:20:25 PST
Created attachment 354186 [details] Patch
Matt Baker
Comment 7 2018-11-07 17:22:19 PST
Comment on attachment 354186 [details] Patch r=me
WebKit Commit Bot
Comment 8 2018-11-07 18:00:57 PST
Comment on attachment 354186 [details] Patch Clearing flags on attachment: 354186 Committed r237973: <https://trac.webkit.org/changeset/237973>
WebKit Commit Bot
Comment 9 2018-11-07 18:00:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.