Bug 191401

Summary:

Add USE(LIBWPE) to WebCore

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Platform

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aperez, cgarcia, commit-queue, mcatanzaro, webkit-bug-importer, zan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Don Olmstead

Reported 2018-11-07 15:18:28 PST

The PlayStation port is planning on having a libwpe implementation but has no plans to use glib. PLATFORM(WPE) = USE(LIBWPE) + USE(GLIB) PLATFORM(PLAYSTATION) = USE(LIBWPE) This will migrate all usage of wpe_* functions to be USE(LIBWPE) rather than PLATFORM(WPE).

Attachments
Patch (9.54 KB, patch) 2018-11-07 15:21 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (22.24 KB, patch) 2018-11-15 18:10 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (22.24 KB, patch) 2018-11-15 18:14 PST, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2018-11-07 15:21:39 PST

Created attachment 354166 [details] Patch

Adrian Perez

Comment 2 2018-11-07 23:32:14 PST

Comment on attachment 354166 [details] Patch Reviewing informally... patch looks good to me. Probably it is a good idea that Žan rubber-stamps this before landing, tho :)

Michael Catanzaro

Comment 3 2018-11-08 06:49:37 PST

Comment on attachment 354166 [details] Patch My only concern is that this is going to introduce some confusion. We're going to be tempted to use GLib in WPE files that can now no longer depend on GLib. So a couple suggestions: * Rename GLContextEGLWPE.cpp to GLContextEGLLibwpe.cpp as a reminder that it's now used on non-WPE platforms. * Rename PlatformDisplayWPE.cpp to PlatformDisplayLibwpe.cpp for the same reason, and rename the class PlatformDisplayWPE to PlatformDisplayLibwpe. An alternative spelling would be LibWPE. See what Zan thinks before making any changes, since he might disagree.

Zan Dobersek

Comment 4 2018-11-12 05:45:39 PST

(In reply to Michael Catanzaro from comment #3) > * Rename GLContextEGLWPE.cpp to GLContextEGLLibwpe.cpp as a reminder that > it's now used on non-WPE platforms. > * Rename PlatformDisplayWPE.cpp to PlatformDisplayLibwpe.cpp for the same > reason, and rename the class PlatformDisplayWPE to PlatformDisplayLibwpe. > > An alternative spelling would be LibWPE. > These make sense, please apply the renames. I'd personally prefer 'LibWPE', but it's not a strong preference.

Michael Catanzaro

Comment 5 2018-11-13 16:38:31 PST

(In reply to Zan Dobersek from comment #4) > These make sense, please apply the renames. And to all the files using USE(LIBWPE), not just the two I mentioned. (E.g. PlatformKeyboardEventLibWPE.cpp.)

Don Olmstead

Comment 6 2018-11-15 18:10:42 PST

Created attachment 355007 [details] Patch

Don Olmstead

Comment 7 2018-11-15 18:14:51 PST

Created attachment 355008 [details] Patch

Don Olmstead

Comment 8 2018-11-15 19:09:44 PST

Ok I think this is good to review. This renames the files and moves to a libwpe location.

WebKit Commit Bot

Comment 9 2018-11-16 08:39:00 PST

Comment on attachment 355008 [details] Patch Clearing flags on attachment: 355008 Committed r238282: <https://trac.webkit.org/changeset/238282>