Bug 191348

Summary: run-bindings-tests is timing out in some WinCairo bots
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Tools / TestsAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, ews-watchlist, fpizlo, ggaren, glenn, lforschler, pvollan, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2018-11-07 00:17:05 PST
[WinCairo] run-bindings-tests is timing out in some bots This issue is happening on wincairo-wkl-release-tests-02, but on wincairo-wkl-release-tests-01. For example, https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/2426/steps/bindings-generation-tests/logs/stdio > command timed out: 1200 seconds without output running ['python', './Tools/Scripts/run-bindings-tests'], attempting to kill > program finished with exit code 1 > elapsedTime=1200.300000 If I set a env var PYTHONUNBUFFERED=1 in wincairo-wkl-release-tests-02, it passed. https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Tests%29/builds/2430/steps/bindings-generation-tests/logs/stdio > PYTHONUNBUFFERED=1 (...) > All tests PASS! > program finished with exit code 0 > elapsedTime=2069.417000
Attachments
Patch (1.57 KB, patch)
2018-11-07 01:18 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2018-11-07 00:19:51 PST
BuildBot kills run-bindings-tests if it outputs nothing for 20 minutes. run-bindings-tests runs very slowly in WinCairo Docker. It takes more than 30 minutes to complete. And, Python buffers the progress output.
Fujii Hironori
Comment 2 2018-11-07 01:18:59 PST
Created attachment 354073 [details] Patch
Ross Kirsling
Comment 3 2018-11-07 08:47:26 PST
Seems reasonable to me.
Brent Fulgham
Comment 4 2018-11-07 08:53:22 PST
Geoff, Filip, any objection to adding this flush? Seems reasonable.
Fujii Hironori
Comment 5 2018-11-09 00:26:44 PST
Review, please.
Fujii Hironori
Comment 6 2018-11-11 18:01:55 PST
Comment on attachment 354073 [details] Patch Clearing flags on attachment: 354073 Committed r238081: <https://trac.webkit.org/changeset/238081>
Fujii Hironori
Comment 7 2018-11-11 18:01:58 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-11 18:03:28 PST
<rdar://problem/45977718>
Note You need to log in before you can comment on or make changes to this bug.