Summary: | Fix steps_unittest.py failures related to recent Win10/Win7 changes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | Tools / Tests | Assignee: | Ryan Haddad <ryanhaddad> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, aperez, ap, bugs-noreply, lforschler, mcatanzaro, pnormand, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=191318 | ||||||
Attachments: |
|
Description
Ryan Haddad
2018-11-05 17:33:38 PST
Created attachment 353936 [details]
Patch
Comment on attachment 353936 [details]
Patch
Why is there a change to GTK steps? Did that change earlier?
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 353936 [details] > Patch > > Why is there a change to GTK steps? Did that change earlier? It appears to be due to: [GTK] Disable MSE build support on Debian and Ubuntu LTS bots https://bugs.webkit.org/show_bug.cgi?id=190581 The GTK/WPE change is wrong and unexpected. We were just trying to disable a build flag, not introduce a new build step. Are we sure this change was related to r237113? Anyway, I'm impressed that the test caught this problem. CC Adrian. Adrian, the problem is the Ubuntu LTS bots have unexpectedly started running a JHBuild environment. They're supposed to be using system dependencies only, not JHBuild. (In reply to Michael Catanzaro from comment #4) > The GTK/WPE change is wrong and unexpected. We were just trying to disable a > build flag, not introduce a new build step. Are we sure this change was > related to r237113? Anyway, I'm impressed that the test caught this problem. I came to this conclusion using git bisect. Checking build history, the step appearance lines up with when I restarted buildbot on October 15th (https://bugs.webkit.org/show_bug.cgi?id=190581#c7). I'll just land the Win10/Win7 portion of my change. Reported bug #191318 for the GTK problem. I landed the Win10/Win7 test fixes in https://trac.webkit.org/changeset/237991/webkit |