Bug 191288

Summary: Feature flags not present for Visual Studio when using build-webkit
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, commit-queue, dbates, ews-watchlist, fujii, lforschler, mcatanzaro, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2018-11-05 16:49:55 PST
Currently none of the feature flags selected in build-webkit end up being passed into a Visual Studio based build.
Attachments
Patch (1.15 KB, patch)
2018-11-05 16:51 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (2.82 KB, patch)
2018-11-06 12:11 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-11-05 16:51:25 PST
Created attachment 353925 [details] Patch
Don Olmstead
Comment 2 2018-11-05 17:18:32 PST
*** Bug 190935 has been marked as a duplicate of this bug. ***
Fujii Hironori
Comment 3 2018-11-05 17:40:21 PST
Comment on attachment 353925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353925&action=review > Tools/Scripts/build-webkit:303 > + if (exitStatus(generateBuildSystemFromCMakeProject($prefixPath, (cmakeBasedPortArguments(), @featureArgs), @cmakeArgs))) { cmakeBasedPortArguments is not used since Bug 136951. I think you should remove it.
Fujii Hironori
Comment 4 2018-11-06 05:21:45 PST
Comment on attachment 353925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353925&action=review >> Tools/Scripts/build-webkit:303 >> + if (exitStatus(generateBuildSystemFromCMakeProject($prefixPath, (cmakeBasedPortArguments(), @featureArgs), @cmakeArgs))) { > > cmakeBasedPortArguments is not used since Bug 136951. I think you should remove it. This inner parenthesis is useless in Perl because Perl flattens nested lists. generateBuildSystemFromCMakeProject($prefixPath, cmakeBasedPortArguments(), @featureArgs, @cmakeArgs)
Don Olmstead
Comment 5 2018-11-06 12:11:29 PST
Created attachment 353984 [details] Patch Updated based on review comments. Removed the unused cmakeBasedPortArguments.
WebKit Commit Bot
Comment 6 2018-11-06 14:10:39 PST
Comment on attachment 353984 [details] Patch Clearing flags on attachment: 353984 Committed r237887: <https://trac.webkit.org/changeset/237887>
WebKit Commit Bot
Comment 7 2018-11-06 14:10:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-11-06 14:12:29 PST
<rdar://problem/45855617>
Note You need to log in before you can comment on or make changes to this bug.