Bug 191275

Summary:

webkitpy: Generalize trailing SDK specifier

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, commit-queue, ews-watchlist, glenn, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	commit-queue: commit-queue-

Jonathan Bedard

Reported 2018-11-05 12:10:11 PST

List all installed SDKs with version numbers stripped out.

Attachments
Patch (3.32 KB, patch) 2018-11-05 12:17 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (3.02 KB, patch) 2018-11-06 08:37 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (4.16 KB, patch) 2018-11-06 12:57 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (2.77 KB, patch) 2018-11-06 14:18 PST, Jonathan Bedard	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Jonathan Bedard

Comment 1 2018-11-05 12:10:28 PST

<rdar://problem/45703660>

Jonathan Bedard

Comment 2 2018-11-05 12:17:25 PST

Created attachment 353899 [details] Patch

WebKit Commit Bot

Comment 3 2018-11-05 16:21:44 PST

Comment on attachment 353899 [details] Patch Clearing flags on attachment: 353899 Committed r237836: <https://trac.webkit.org/changeset/237836>

WebKit Commit Bot

Comment 4 2018-11-05 16:21:45 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 5 2018-11-05 16:22:21 PST

<rdar://problem/45825307>

Jonathan Bedard

Comment 6 2018-11-06 08:37:16 PST

Reopening to attach new patch.

Jonathan Bedard

Comment 7 2018-11-06 08:37:17 PST

Created attachment 353970 [details] Patch

Jonathan Bedard

Comment 8 2018-11-06 12:57:31 PST

Created attachment 353991 [details] Patch

Aakash Jain

Comment 9 2018-11-06 13:07:49 PST

Comment on attachment 353991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353991&action=review > Tools/Scripts/webkitpy/port/ios_simulator.py:84 > + return ['--sdk', self.SDK] + (['ARCHS={}'.format(self.architecture())] if self.architecture() else []) Is the architecture change unrelated? If so, it probably needs to be in a separate patch.

Jonathan Bedard

Comment 10 2018-11-06 14:18:16 PST

Created attachment 354004 [details] Patch

Jonathan Bedard

Comment 11 2018-11-06 14:19:02 PST

(In reply to Aakash Jain from comment #9) > Comment on attachment 353991 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353991&action=review > > > Tools/Scripts/webkitpy/port/ios_simulator.py:84 > > + return ['--sdk', self.SDK] + (['ARCHS={}'.format(self.architecture())] if self.architecture() else []) > > Is the architecture change unrelated? If so, it probably needs to be in a > separate patch. It was some code clean-up, I removed it. (It wasn't actually a functional change)

WebKit Commit Bot

Comment 12 2018-11-06 21:01:38 PST

Comment on attachment 354004 [details] Patch Clearing flags on attachment: 354004 Committed r237913: <https://trac.webkit.org/changeset/237913>

WebKit Commit Bot

Comment 13 2018-11-06 21:01:40 PST

All reviewed patches have been landed. Closing bug.

Jonathan Bedard

Comment 14 2018-11-07 11:25:41 PST

Reverted r237913 for reason: Breaks running tests on Mac without iOS SDK installed Committed r237931: <https://trac.webkit.org/changeset/237931>

Jonathan Bedard

Comment 15 2018-11-07 15:50:49 PST

(In reply to Jonathan Bedard from comment #14) > Reverted r237913 for reason: > > Breaks running tests on Mac without iOS SDK installed > > Committed r237931: <https://trac.webkit.org/changeset/237931> I'll re-land this tonight, this patch was (and is) fine, there is just a specific local configuration problem that causes this patch to fail, I'll reach out to those who might be impacted.

WebKit Commit Bot

Comment 16 2018-11-07 22:26:31 PST

Comment on attachment 354004 [details] Patch Rejecting attachment 354004 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 354004, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Tools/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/9904967

Jonathan Bedard

Comment 17 2018-11-08 08:16:20 PST

Committed r237989: <https://trac.webkit.org/changeset/237989>

Note You need to log in before you can comment on or make changes to this bug.