Bug 191254

Summary: Align wide opcodes in the instruction stream
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dominik.infuehr, ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, ryanhaddad, saam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews107 for mac-sierra-wk2 none

Tadeu Zagallo
Reported 2018-11-05 01:59:01 PST
Pad the bytecode with nops to ensure that wide opcodes are 4-byte aligned on platforms that don't like unaligned memory access.
Attachments
Patch (32.26 KB, patch)
2018-11-05 02:09 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Patch (32.31 KB, patch)
2018-11-05 08:37 PST, Tadeu Zagallo 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.73 MB, application/zip)
2018-11-05 13:45 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2018-11-05 02:09:39 PST
Created attachment 353839 [details] Patch
Tadeu Zagallo
Comment 2 2018-11-05 08:37:56 PST
Created attachment 353865 [details] Patch
Tadeu Zagallo
Comment 3 2018-11-05 09:17:09 PST
<rdar://problem/45739094>
EWS Watchlist
Comment 4 2018-11-05 13:45:35 PST
Comment on attachment 353865 [details] Patch Attachment 353865 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9869160 New failing tests: imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-tracks.https.html
EWS Watchlist
Comment 5 2018-11-05 13:45:37 PST
Created attachment 353905 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Keith Miller
Comment 6 2018-11-07 11:02:49 PST
Comment on attachment 353865 [details] Patch r=me.
WebKit Commit Bot
Comment 7 2018-11-07 11:38:23 PST
Comment on attachment 353865 [details] Patch Clearing flags on attachment: 353865 Committed r237933: <https://trac.webkit.org/changeset/237933>
WebKit Commit Bot
Comment 8 2018-11-07 11:38:25 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.